Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use result<T&> in accessor functions #941

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Use result<T&> in accessor functions #941

merged 5 commits into from
Jun 19, 2024

Conversation

grisumbras
Copy link
Member

No description provided.

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.30508% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.40%. Comparing base (3d334a7) to head (12a4e77).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #941      +/-   ##
===========================================
+ Coverage    93.34%   93.40%   +0.05%     
===========================================
  Files           87       87              
  Lines         8490     8622     +132     
===========================================
+ Hits          7925     8053     +128     
- Misses         565      569       +4
Files Coverage Δ
include/boost/json/array.hpp 100.00% <ø> (ø)
include/boost/json/impl/array.hpp 100.00% <100.00%> (ø)
include/boost/json/impl/array.ipp 100.00% <100.00%> (ø)
include/boost/json/impl/object.hpp 100.00% <100.00%> (ø)
include/boost/json/impl/object.ipp 100.00% <100.00%> (ø)
include/boost/json/impl/pointer.ipp 100.00% <100.00%> (ø)
include/boost/json/impl/string.hpp 98.52% <100.00%> (+0.06%) ⬆️
include/boost/json/impl/string.ipp 100.00% <100.00%> (ø)
include/boost/json/impl/value.hpp 100.00% <100.00%> (ø)
include/boost/json/object.hpp 100.00% <ø> (ø)
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d334a7...12a4e77. Read the comment docs.

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

@grisumbras grisumbras merged commit e23879d into boostorg:develop Jun 19, 2024
7 checks passed
@grisumbras grisumbras deleted the feature/use-result-ref branch June 19, 2024 11:33
@grisumbras grisumbras mentioned this pull request Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grisumbras @cppalliance-bot