fix value_to for variants #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After we allowed exceptions to propagate through error_code-based conversions (when the user invoked value_to, rather than try_value_to), we inadvertently broke value_to for variants, because they relied on exceptions being caught by try_value_to. This change disables exception propagation for exactly one level of nesting.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #999 +/- ##
========================================
Coverage 93.08% 93.08%
========================================
Files 87 87
Lines 8125 8125
========================================
Hits 7563 7563
Misses 562 562
Continue to review full report in Codecov by Sentry.
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we allowed exceptions to propagate through error_code-based conversions (when the user invoked value_to, rather than try_value_to), we inadvertently broke value_to for variants, because they relied on exceptions being caught by try_value_to. This change disables exception propagation for exactly one level of nesting.