Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of non BOOST-prefixed macros #88

Open
ned14 opened this issue Dec 16, 2019 · 3 comments
Open

List of non BOOST-prefixed macros #88

ned14 opened this issue Dec 16, 2019 · 3 comments

Comments

@ned14
Copy link
Member

ned14 commented Dec 16, 2019

The following macros are missing a BOOST_ prefix, which is against Boost library guidelines:

./boost/program_options.hpp:#ifndef PROGRAM_OPTIONS_VP_2003_05_19
./boost/program_options.hpp:#define PROGRAM_OPTIONS_VP_2003_05_19
./boost/program_options/config.hpp:#endif // PROGRAM_OPTIONS_CONFIG_HK_2004_01_11
@vprus
Copy link
Collaborator

vprus commented Dec 17, 2019

Would you mind preparing a PR?

@ned14
Copy link
Member Author

ned14 commented Dec 17, 2019

Unfortunately I am not the one doing the work, I merely uploaded the results of another's work. Also, I cannot contribute work-related code without going through Legal first.

@vprus
Copy link
Collaborator

vprus commented Dec 17, 2019

Ok. While I might tweak this myself, the priority of the cosmetics that did not cause any real issues for 16 years is pretty low.

aboualiaa added a commit to aboualiaa/program_options that referenced this issue Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants