Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove outdated images #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove outdated images #1

wants to merge 1 commit into from

Conversation

acxz
Copy link

@acxz acxz commented Jul 12, 2024

ubuntu-boost-tbb is obselete and gtsam has been updated in the borglab/gtsam github repo

follow up of borglab/gtsam#1779 and borglab/gtsam#1780 (comment)
I imagine this is temporary, but in any case, we should still be consistent and not have duplicate containerfiles for images across our organization.

Once it is decided where the images should reside (and if it that location is in this repo), we can open up a merge request here and remove the containers/ folder in the main borglab/gtsam github repo.

ubuntu-boost-tbb is obselete and gtsam has been updated in the borglab/gtsam github repo
@acxz
Copy link
Author

acxz commented Jul 19, 2024

@varunagrawal any activity regarding this? We have two versions of containers in our ecosystem.

@varunagrawal
Copy link
Collaborator

@acxz I think you misunderstood my original comments about a common repository for docker images. The goal would be to have all the images in this repo as the common source of truth. Over time, I would like to remove the containers directory from the GTSAM repo and other software repos in favor of the image definitions here.
That way, we can run CI to build the images and push to DockerHub or have DockerHub directly access this repo and build the images from here.

Given this need, the changes in this PR will have to be updated.

@acxz
Copy link
Author

acxz commented Jul 21, 2024

I agree with. However, the first step is to get rid of unused containers. The next step is to remove the containers from gtsam repo and add them in this repo. This PR is simply the first step.

The containers that are being removed in this PR are not being used at all and hence serve no purpose, besides confusing users who come across this repo and the images on dockerhub.

@varunagrawal
Copy link
Collaborator

varunagrawal commented Jul 21, 2024

However, the first step is to get rid of unused containers. The next step is to remove the containers from gtsam repo and add them in this repo. This PR is simply the first step.

Disagree. We can update this repo and make it work very well so that when we flip the switch to use the containers here and delete the those in other repos, there is no disruption.

The containers that are being removed in this PR are not being used at all and hence serve no purpose, besides confusing users who come across this repo and the images on dockerhub.

That's not true. I use these containers and there may be others as well. :)
Due to this same confusion I am suggesting getting the Dockerfiles here updated without deleting anything so there is no point at which this repo doesn't have working image definitions.

As to your point about Dockerhub, these images are no longer on Dockerhub so no one should be coming to this repo via that route.

@varunagrawal
Copy link
Collaborator

@acxz we have received approval for the Docker OSS program 🎉
If you have the bandwidth, I can add you to the Docker org, approve this PR and get the autobuilds going as soon as possible. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants