RecentLoginRequiredMixin tests and first pass #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, should be good for merging now. Check it out, @chrisjones-brack3t ? |
| """ | ||
| Mixin allows you to require a login to be within a number of seconds. | ||
| """ | ||
| max_last_login_delta = 1800 # Defaults to 30 minutes |
There was a problem hiding this comment.
Might think about adding a get method for this so that it can be overridden. Someone might want to perform some logic and set the amount of time based on that.
There was a problem hiding this comment.
In this case a @property could also be used, couldn't it?
|
👍 |
chrisjones-brack3t
added a commit
that referenced
this pull request
Apr 17, 2015
RecentLoginRequiredMixin tests and first pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready to merge yet but address #138.