New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Drop parallel's apply for futurized counterpart #31

Merged

brandmaier merged 1 commit into brandmaier:master from octomike:feature_futureapply

Jun 3, 2021

Contributor

octomike commented Jun 3, 2021

This simple PR replaces all occurrances of parallel::parXapply with their future.apply counterparts. With this change you can:

enable users to use their own (parallel) execution strategy (the demos use plan(multisession))
stop creating static cluster objects and stop carrying them around
remove some checks and code duplication
(imho) ignore the seed demo, because future.seeds = T should take care of the RNG state

I think this branch still needs:

A hint for new users that, by default, future.apply does things sequentially (README or just demos?)
updated docs/ and man/ (how do you do that here exactly?)

I'm happy to include additional changes and discuss the general idea of course. Let me know :)


          Drop parallel's apply for futurized counterpart

614ef04

brandmaier merged commit 5fdd8f8 into brandmaier:master

Owner

brandmaier commented Jun 3, 2021

This is awesome and a great improvement to the parallelizability of semtree! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet