Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stronger PHP types #19

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

Chris53897
Copy link

i would suggest to check and merge after ci is up and running.

@bresam
Copy link
Owner

bresam commented Feb 21, 2024

to be merged now or should i wait?

Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Chris53897
Copy link
Author

CI has the same 8 errors as i have local.
This can be merged.
The errors needs to be adressed in an seperate PR.

@bresam bresam merged commit 5d1ea55 into bresam:v6 Feb 21, 2024
1 of 6 checks passed
@Chris53897 Chris53897 deleted the feature/strong-types branch February 21, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants