WX-964 suffix() #7363
WX-964 suffix() #7363
Conversation
| expressionValueEvaluator | ||
| ) | ||
| ) { (suffix, arr) => | ||
| EvaluatedValue(WomArray(arr.value.map(v => WomString(v.valueString + suffix.value))), Seq.empty).validNel |
There was a problem hiding this comment.
This is the part that actually does the suffix-ing
| final case class Suffix(suffix: ExpressionElement, array: ExpressionElement) extends TwoParamFunctionCallElement { | ||
| override def arg1: ExpressionElement = suffix | ||
| override def arg2: ExpressionElement = array | ||
| } |
There was a problem hiding this comment.
draft-3 is not supposed to support suffix, right?
There was a problem hiding this comment.
No, but all the other post-1.0 engine functions (ex. min, max, sep) have their case classes in here so I followed that convention. There aren't equivalent files in the other language version packages, though I can make that change if desirable.
There was a problem hiding this comment.
I feel like those functions may have been put in there before a next language version was declared and/or before we had our current organization scheme. I do think that separating them out (both current and the new addition) would be optimal, though maybe that's a separate ticket.
There was a problem hiding this comment.
Discussed off-github and decided to leave this as-is.
wdl/transforms/new-base/src/main/scala/wdl/transforms/base/wdlom2wdl/WdlWriterImpl.scala
Show resolved
Hide resolved
Adds support for
suffixengine function. This function was added in WDL 1.1, so Cromwell support has been added for WDL versions starting with our 1.1 development branch.suffixsupportdraft-2draft-21.01.0draft-3(AKAarcadia... in my heart)1.1development-1.1biscayne1.2or2.0)developmentcascades