-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WX-963] Unzip Engine Function #7368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Reviewing this made me think about how we don't seem to have much unit testing of failure modes (my suffix PR suffered from the same issue) - what if I run a WDL with unzip([("banana", 5), (6, "apple"])
? Is that valid, or does it fail because we can't find good types for the output arrays?
...est/scala/wdl/transforms/cascades/linking/expression/values/CascadesValueEvaluatorSpec.scala
Show resolved
Hide resolved
@@ -64,4 +64,12 @@ class CascadesTypeEvaluatorSpec extends AnyFlatSpec with CromwellTimeoutSpec wit | |||
e.evaluateType(Map.empty) shouldBeValid WomArrayType(WomStringType) | |||
} | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's another test in the Biscayne version, should it be added here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're still missing a test here that is is Biscayne, no? Once that's in I think this is good to go!
Agree with this sentiment! I added a few unit tests for basic failure modes. To your more specific question: However, unzip |
Implemented the unzip() engine function, new with WDL 1.1.
As a new WDL 1.1 feature, it was implemented for
Biscayne
andCascades
, but not earlier versions (e.g.draft-2
,draft-3
).