Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WX-965] quote() and squote() engine functions. #7375

Merged
merged 14 commits into from
Feb 29, 2024
Merged

[WX-965] quote() and squote() engine functions. #7375

merged 14 commits into from
Feb 29, 2024

Conversation

rsaperst
Copy link
Contributor

Implemented quote() and squote() engine functions, which are new with WDL 1.1.

As a new WDL 1.1 feature, it was implemented for Biscayne and Cascades, but not earlier versions (e.g. draft-2, draft-3).

@rsaperst rsaperst marked this pull request as ready for review February 26, 2024 18:31
@rsaperst rsaperst requested a review from a team as a code owner February 26, 2024 18:31
@aednichols
Copy link
Collaborator

Holding off a thumb until we everything compiling and passing.

Pro tip, you can force full compilation of tests without running all of them by issuing Test / compile at the SBT prompt.

Copy link
Contributor

@jgainerdewar jgainerdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! Assuming tests pass with the latest changes from develop, looks good to me!

@rsaperst rsaperst merged commit db0dd2d into develop Feb 29, 2024
34 checks passed
@rsaperst rsaperst deleted the wx965 branch February 29, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants