Skip to content

Commit

Permalink
restore epsilon, add debugging statement
Browse files Browse the repository at this point in the history
  • Loading branch information
droazen committed Dec 11, 2023
1 parent 5576927 commit 636d139
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public static void runH5Diff(final String expected, final String actual) {
// -r: Report mode. Print the differences.
// --use-system-epsilon: Return a difference if and only if the difference between two data values exceeds
// the system value for epsilon.
final String[] command = new String[] { "h5diff", "-r", expected, actual };
final String[] command = new String[] { "h5diff", "-r", "--use-system-epsilon", expected, actual };

Check warning on line 46 in src/test/java/org/broadinstitute/hellbender/tools/walkers/vqsr/scalable/ScoreVariantAnnotationsIntegrationTest.java

View check run for this annotation

Codecov / codecov/patch

src/test/java/org/broadinstitute/hellbender/tools/walkers/vqsr/scalable/ScoreVariantAnnotationsIntegrationTest.java#L46

Added line #L46 was not covered by tests

runProcessAndCaptureOutputInExceptionMessage(controller, command);
}

Check warning on line 49 in src/test/java/org/broadinstitute/hellbender/tools/walkers/vqsr/scalable/ScoreVariantAnnotationsIntegrationTest.java

View check run for this annotation

Codecov / codecov/patch

src/test/java/org/broadinstitute/hellbender/tools/walkers/vqsr/scalable/ScoreVariantAnnotationsIntegrationTest.java#L48-L49

Added lines #L48 - L49 were not covered by tests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public static void runH5Diff(final String expected, final String actual) {
// -r: Report mode. Print the differences.
// --use-system-epsilon: Return a difference if and only if the difference between two data values exceeds
// the system value for epsilon.
final String[] command = new String[] { "h5diff", "-r", expected, actual };
final String[] command = new String[] { "h5diff", "-r", "--use-system-epsilon", expected, actual };

Check warning on line 48 in src/test/java/org/broadinstitute/hellbender/tools/walkers/vqsr/scalable/TrainVariantAnnotationsModelIntegrationTest.java

View check run for this annotation

Codecov / codecov/patch

src/test/java/org/broadinstitute/hellbender/tools/walkers/vqsr/scalable/TrainVariantAnnotationsModelIntegrationTest.java#L48

Added line #L48 was not covered by tests

runProcessAndCaptureOutputInExceptionMessage(controller, command);
}

Check warning on line 51 in src/test/java/org/broadinstitute/hellbender/tools/walkers/vqsr/scalable/TrainVariantAnnotationsModelIntegrationTest.java

View check run for this annotation

Codecov / codecov/patch

src/test/java/org/broadinstitute/hellbender/tools/walkers/vqsr/scalable/TrainVariantAnnotationsModelIntegrationTest.java#L50-L51

Added lines #L50 - L51 were not covered by tests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@ public static void runProcess(final ProcessController processController, final S
final String fullMessage = includeProcessOutputInExceptionMessage ?
message + "\n***Process stdout:***\n" + output.getStdout() + "\n***Process stderr:***\n" + output.getStderr() :
message;

// Temporarily print the stdout/stderr unconditionally, for debugging
System.err.println(fullMessage);

Assert.assertEquals(output.getExitValue(), 0, fullMessage);
}

Expand Down

0 comments on commit 636d139

Please sign in to comment.