Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check sequence dictionary compatibility at startup #101

Closed
droazen opened this issue Jan 13, 2015 · 4 comments
Closed

Check sequence dictionary compatibility at startup #101

droazen opened this issue Jan 13, 2015 · 4 comments
Assignees
Labels

Comments

@droazen
Copy link
Collaborator

droazen commented Jan 13, 2015

We need to port the GATK code that checks sequence dictionary compatibility of reads vs reference, and have this check run at startup, since the engine assumes compatibility. This will require a few modifications, since the legacy code is hardcoded to look for certain references/contigs in a few places, such as where it checks for non-canonical human ordering.

@droazen droazen added the Engine label Jan 13, 2015
@akiezun akiezun added this to the Aye-aye milestone Jan 13, 2015
@akiezun
Copy link
Contributor

akiezun commented Feb 20, 2015

is this happening for AyeAye?

@droazen droazen modified the milestones: BlobFish, Aye-aye Feb 24, 2015
@droazen droazen modified the milestones: Coelacanth, BlobFish Apr 6, 2015
@droazen
Copy link
Collaborator Author

droazen commented Apr 8, 2015

Note that a compatibility check was added to CachingIndexedFastaSequenceFile as part of #357. We might be able to remove this check once we have comprehensive up-front compatibility checks in place.

@akiezun akiezun modified the milestone: Coelacanth Apr 20, 2015
@droazen droazen assigned edwardkw and unassigned droazen Jun 17, 2015
@droazen
Copy link
Collaborator Author

droazen commented Jun 18, 2015

This will require porting SequenceDictionaryUtils.validateDictionaries() from the old GATK.

@droazen
Copy link
Collaborator Author

droazen commented Jun 18, 2015

Step #1: Port as much of SequenceDictionaryUtils as needed from the old GATK (remove garbage like validation exclusions, fix terrible things like non-canonical human order check if possible, if not create tickets). Port unit tests as well.

Step #2: Hook up sequence dictionary validation to hellbender engine, and add integration tests to prove that dictionary incompatibilities are detected. Best place to hook this up is probably GATKTool.onStartup(), since it manages all the engine-level inputs for tools.

lucidtronix added a commit that referenced this issue Jul 27, 2021
* default tensor from file mostly removed, group is gone, source becomes path_prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants