-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to filter variants based on QC in ArrayExtractCohort #6844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganshand
reviewed
Sep 22, 2020
// if we have a qcMetrics table, augment the probeInfo map with that information | ||
Map<Long, ProbeQcMetrics> probeQcMetricsMap = null; | ||
if (qcMetricsTableName != null) { | ||
probeQcMetricsMap = ProbeQcMetrics.getProbeQcMetricsWithStorageAPI(qcMetricsTableName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this class, did you commit ProbeQcMetrics
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did now 😅
meganshand
approved these changes
Sep 22, 2020
meganshand
pushed a commit
that referenced
this pull request
Oct 6, 2020
* incorporate QC data into extract
kcibul
added a commit
that referenced
this pull request
Jan 29, 2021
* incorporate QC data into extract
kcibul
added a commit
that referenced
this pull request
Jan 29, 2021
* incorporate QC data into extract
kcibul
added a commit
that referenced
this pull request
Feb 1, 2021
* incorporate QC data into extract
kcibul
added a commit
that referenced
this pull request
Feb 1, 2021
* incorporate QC data into extract
Marianie-Simeon
pushed a commit
that referenced
this pull request
Feb 16, 2021
* incorporate QC data into extract
Marianie-Simeon
pushed a commit
that referenced
this pull request
Feb 16, 2021
* incorporate QC data into extract
kcibul
added a commit
that referenced
this pull request
Mar 9, 2021
* incorporate QC data into extract
kcibul
added a commit
that referenced
this pull request
Mar 9, 2021
* incorporate QC data into extract
mmorgantaylor
pushed a commit
that referenced
this pull request
Apr 6, 2021
* incorporate QC data into extract
mmorgantaylor
pushed a commit
that referenced
this pull request
Apr 6, 2021
* incorporate QC data into extract
mmorgantaylor
pushed a commit
that referenced
this pull request
Apr 6, 2021
* incorporate QC data into extract
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/broadinstitute/dsp-spec-ops/issues/189