add in feature extract code. resulting vcf still has bugs #6947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcibul
approved these changes
Nov 10, 2020
| public final static Comparator<GenericRecord> LOCATION_COMPARATOR = new Comparator<GenericRecord>() { | ||
| @Override | ||
| public int compare( GenericRecord o1, GenericRecord o2 ) { | ||
| final long firstProbeId = (Long) o1.get(SchemaUtils.LOCATION_FIELD_NAME); |
There was a problem hiding this comment.
rename variables --- e.g. firstLocation instead of firstProbeId
| @@ -73,15 +73,14 @@ public static String getSampleId(final String sampleName, final File sampleMap) | |||
| // Since tables have a limited number of samples (default is 4k) | |||
| public static int getTableNumber(String sampleId, int sampleMod) { // this is based on sample id | |||
| // sample ids 1-4000 will go in directory 001 | |||
| int sampleIdInt = Integer.valueOf(sampleId); // TODO--should sampleId just get refactored as a long? | |||
| long sampleIdInt = Long.valueOf(sampleId); // TODO--should sampleId just get refactored as a long? | |||
There was a problem hiding this comment.
rename variable, maybe just sampleId and change the parameter to the function to be sampleIdString. MAybe remove the TODO
kcibul
pushed a commit
that referenced
this pull request
Jan 29, 2021
* add in feature extract code. resulting vcf still has bugs
kcibul
pushed a commit
that referenced
this pull request
Feb 1, 2021
* add in feature extract code. resulting vcf still has bugs
Marianie-Simeon
pushed a commit
that referenced
this pull request
Feb 16, 2021
* add in feature extract code. resulting vcf still has bugs
kcibul
pushed a commit
that referenced
this pull request
Mar 9, 2021
* add in feature extract code. resulting vcf still has bugs
mmorgantaylor
pushed a commit
that referenced
this pull request
Apr 6, 2021
* add in feature extract code. resulting vcf still has bugs
mmorgantaylor
pushed a commit
that referenced
this pull request
Apr 6, 2021
* add in feature extract code. resulting vcf still has bugs
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.