fixing bug in filtering on export from variantstore #6976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganshand
requested review from
kcibul and
ahaessly
and removed request for
kcibul
kcibul
pushed a commit
that referenced
this pull request
Jan 29, 2021
kcibul
pushed a commit
that referenced
this pull request
Feb 1, 2021
Marianie-Simeon
pushed a commit
that referenced
this pull request
Feb 16, 2021
kcibul
pushed a commit
that referenced
this pull request
Mar 9, 2021
mmorgantaylor
pushed a commit
that referenced
this pull request
Apr 6, 2021
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug I noticed while spot checking sites. We should eventually add some tests that check expected outputs, but I'll save that for another day. We were accidentally applying filters to alleles in the filtering table that didn't exist in the cohort that was pulled out. Now we're only looking at VQSLODs in the filter table for alleles that are present in the output VCF.