ah - optional service account #7140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localize with service account in same vm update disk size fix input_vcf to work with manual localization and streaming
kcibul
approved these changes
Mar 10, 2021
| } | ||
|
|
||
| Int multiplier = if defined(drop_state) then 4 else 10 | ||
| Int disk_size = ceil(size(input_vcf, "GB") * multiplier) + 20 | ||
| #TODO does this affect the memory allocation for the disk? | ||
| Int disk_size = 1000 |
There was a problem hiding this comment.
Maybe turn this into a parameter for the task and workflow with a default so it could be overridden if necessary but works for the "drop GQ60" case. 1000 GB (1TB) seems like a LOT of disk though, is that how big the PET/VET TSVs are?
There was a problem hiding this comment.
the biggest one I see is 7.2 GB. I guess I'll change it to something like 50GB
mmorgantaylor
approved these changes
Mar 11, 2021
mmorgantaylor
pushed a commit
that referenced
this pull request
Apr 6, 2021
* add in service account auth for aou * localize with service account in same vm * modify disk_size based on drop_state
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add in service account auth for aou
localize with service account in same vm
update disk size
fix input_vcf to work with manual localization and streaming