ExtractFeatures supports -XL exclusion and follows intervals, other optimizations #7184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcibul
approved these changes
Apr 6, 2021
src/main/java/org/broadinstitute/hellbender/tools/variantdb/nextgen/ExtractFeaturesEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/hellbender/tools/variantdb/nextgen/ExtractFeaturesRecord.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/hellbender/tools/variantdb/nextgen/ExtractFeaturesRecord.java
Show resolved
Hide resolved
mmorgantaylor
commented
Apr 6, 2021
| this.start = SchemaUtils.decodePosition(location); | ||
| this.end = start; | ||
|
|
||
| this.ref = Objects.toString(genericRecord.get("ref"), null); |
There was a problem hiding this comment.
@kcibul should I add all these strings to SchemaUtils instead?
There was a problem hiding this comment.
i'm going with "not in this PR"
mmorgantaylor
force-pushed
the
mmt_extract_features_records
branch
from
6ce62b9
to
009f9ce
Compare
kcibul
approved these changes
Apr 7, 2021
.dockstore.yml
Outdated
| @@ -96,6 +96,7 @@ workflows: | |||
| branches: | |||
| - master | |||
| - ah_var_store | |||
| - mmt_extract_features_records | |||
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses specops issues:
similar changes as the PR for ExtractCohort:
ExtractFeaturesRecordthat implementsLocatableLocatables, can useOverlapDetectorto filter locations down to only desired intervals (including excluded sites)also: