Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in CreateVariantIngestFiles, set default drop_state to 60, but allow NONE as input #7206

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

mmorgantaylor
Copy link
Member

  • updated integration test (removed that argument so it defaults to the same thing)
  • tested that using "NONE" as an argument works

@mmorgantaylor mmorgantaylor changed the title default drop_state to 60, but allow NONE as input in CreateVariantIngestFiles, set default drop_state to 60, but allow NONE as input Apr 16, 2021
Copy link
Contributor

@kcibul kcibul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- except for making me remember how the 'GQ > x' was implemented due to the enum... backing away slowly

@mmorgantaylor
Copy link
Member Author

lgtm -- except for making me remember how the 'GQ > x' was implemented due to the enum... backing away slowly

yeah that's pretty gross. didn't want to touch it with a ten-foot pole -- but i looked through and checked that the logic will work as intended if you use "NONE" (it just adds nothing to the set of states to ignore)

@mmorgantaylor mmorgantaylor merged commit e050716 into ah_var_store Apr 16, 2021
@mmorgantaylor mmorgantaylor deleted the mmt_drop_state_default branch April 16, 2021 17:42
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants