upgrade bq libraries #7264
Merged
upgrade bq libraries #7264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoriCremer
reviewed
May 25, 2021
| .setTableId(tableRef.tableName) | ||
| .build(); | ||
| final String srcTable = | ||
| String.format( |
There was a problem hiding this comment.
Are there no longer tableReference objects, just table objects? Doing this with a builder pattern feels cleaner
RoriCremer
approved these changes
May 25, 2021
ahaessly
approved these changes
May 26, 2021
| @@ -22,11 +27,9 @@ | |||
|
|
|||
| private static final Logger logger = LogManager.getLogger(StorageAPIAvroReader.class); | |||
|
|
|||
| private static int rowCount = 0; | |||
| private BigQueryReadClient client; | |||
There was a problem hiding this comment.
now that google renamed storageAPI to ReadAPI, should we rename this class? not super important.
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by Micah @ Google, see broadinstitute/dsp-spec-ops#309