Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at a Terra QuickStart #7267

Merged
merged 5 commits into from
Jun 16, 2021
Merged

First pass at a Terra QuickStart #7267

merged 5 commits into from
Jun 16, 2021

Conversation

kcibul
Copy link
Contributor

@kcibul kcibul commented May 21, 2021

@kcibul kcibul changed the title first pass First pass at a Terra QuickStart May 21, 2021
Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some updates based on permissions issues I ran into and then some nitpicks/suggestions about language.

scripts/variantstore/TERRA_QUICKSTART.md Outdated Show resolved Hide resolved
scripts/variantstore/TERRA_QUICKSTART.md Outdated Show resolved Hide resolved

This quickstart assumes that you are familiar with Terra workspaces, the data model and providing input parameters and launching workflows.

1. You will need to have or create a BigQuery dataset (we'll call this `datasetname` later on).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to add roles (for prerequisites 2 & 3 as an "Editor")

Suggested change
1. You will need to have or create a BigQuery dataset (we'll call this `datasetname` later on).
1. You will need to have or create a BigQuery dataset (we'll call this `datasetname` later on) in a Google project where you are an "Owner."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because you need to be an owner so that you can grant these IAM roles? Or do you need to be owner for some other reason (ie say someone else granted you these roles, would that work?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also -- the directions didn't really talk about making a temp dataset... was that a problem? did you have to make one @rsasch ?

Copy link

@rsasch rsasch Jun 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because you need to be an owner so that you can grant these IAM roles? Or do you need to be owner for some other reason (ie say someone else granted you these roles, would that work?)

Yes, I needed to be "Owner" to add those roles for my proxy group. I didn't test a scenario where those roles were added by someone else. I believe being "Owner" also solved the error localizing GATK (my pet needed "storage.objects.list" access to the Google Cloud Storage bucket.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also -- the directions didn't really talk about making a temp dataset... was that a problem? did you have to make one @rsasch ?

I think I might have mis-read my notes. It looks like I ran into the issue in the CreateVetTables call: “BigQuery error in mk operation: Access Denied: Dataset”, but it worked once I used “BigQuery Data Editor” instead.

scripts/variantstore/TERRA_QUICKSTART.md Outdated Show resolved Hide resolved
scripts/variantstore/TERRA_QUICKSTART.md Outdated Show resolved Hide resolved
scripts/variantstore/TERRA_QUICKSTART.md Outdated Show resolved Hide resolved
@kcibul kcibul merged commit 622063b into ah_var_store Jun 16, 2021
@kcibul kcibul deleted the kc_terra_quickstart branch June 16, 2021 17:12
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants