Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ah fix timestamp query #7319

Merged
merged 4 commits into from
Jun 18, 2021
Merged

Ah fix timestamp query #7319

merged 4 commits into from
Jun 18, 2021

Conversation

ahaessly
Copy link
Contributor

@ahaessly ahaessly commented Jun 16, 2021

create .bigqueryrc to suppress warning messages
change disk size to 150

…n access

use project and dataset in BQ query

change disk size
Copy link
Contributor

@kcibul kcibul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahaessly ahaessly requested a review from ericsong June 16, 2021 19:51

LASTMODIFIED=$(bq show ~{"--project_id " + query_project} --location=US --format=json ${DATASET_TABLE_COLON} | python3 -c "import sys, json; print(json.load(sys.stdin)['lastModifiedTime']);")
# bq needs the project name to be separate by a colon
DATASET_TABLE_COLON=$(echo ~{fq_table} | sed 's/\./:/')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to confirm... this only replaces the first instance of a . correct, not all of them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct. there is no '/g' at the end which means replace all of them.
tested on an extract of the 3 controls

Copy link

@ericsong ericsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks for the changes

@ahaessly ahaessly merged commit d4ceba2 into ah_var_store Jun 18, 2021
@ahaessly ahaessly deleted the ah_fix_timestamp_query branch June 18, 2021 20:35
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants