Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize create filterset by breaking out the 3 filter set file creation/loads into separate tasks #7342

Merged
merged 10 commits into from
Jul 19, 2021

Conversation

rsasch
Copy link

@rsasch rsasch commented Jul 8, 2021

The diff is probably a little confusing to look at because code was moved around.

Closes https://github.com/broadinstitute/dsp-spec-ops/issues/322

TODO before merge:

  • remove changes to .dockstore.yml

@rsasch rsasch self-assigned this Jul 8, 2021
Copy link
Contributor

@kcibul kcibul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@ahaessly ahaessly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gatk-bot
Copy link

Travis reported job failures from build 34968
Failures in the following jobs:

Test Type JDK Job ID Logs
integration openjdk11 34968.12 logs

@rsasch rsasch merged commit 7415b33 into ah_var_store Jul 19, 2021
@rsasch rsasch deleted the rsa_parallelize_create_filterset branch July 19, 2021 16:16
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants