Replace service_account_json (file) with service_account_json_path (string) to allow call-caching #7347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoriCremer
approved these changes
Jul 13, 2021
|
|
||
| # runtime | ||
| Int? preemptible_tries | ||
| } | ||
|
|
||
| String has_service_account_file = if (defined(service_account_json)) then 'true' else 'false' | ||
| String has_service_account_file = if (defined(service_account_json_path)) then 'true' else 'false' |
There was a problem hiding this comment.
why are these a string and not a boolean?
There was a problem hiding this comment.
My guess would be that testing a boolean value in bash that was set in WDL is not particularly straightforward.
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, when json is refreshed, contents of the file are different, hash of the file is different, and call-caching will not register a match, despite the same "account" being used.
FiletoStringCloses https://github.com/broadinstitute/dsp-spec-ops/issues/327