Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom annotations as ac an af #7351

Merged
merged 16 commits into from
Jul 23, 2021
Merged

Add custom annotations as ac an af #7351

merged 16 commits into from
Jul 23, 2021

Conversation

RoriCremer
Copy link
Contributor

@RoriCremer RoriCremer commented Jul 15, 2021 •
edited
Loading

Screen Shot 2021-07-15 at 1 58 32 PM

@RoriCremer RoriCremer marked this pull request as ready for review July 19, 2021 16:06
@ahaessly ahaessly self-assigned this Jul 22, 2021
@ahaessly ahaessly self-requested a review July 22, 2021 15:20
@ahaessly ahaessly removed their assignment Jul 22, 2021
rsasch
rsasch reviewed Jul 23, 2021
View reviewed changes
scripts/variantstore/wdl/GvsSitesOnlyVCF.wdl Outdated
# ------------------------------------------------
# Runtime settings:
runtime {
docker: "biocontainers/bcftools:v1.9-1-deb_cv1" # TODO lets put bcftools in our custom container please
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is really something we want to do, please create a "tech debt" ticket for this and remove this comment. I think it might be more likely to get done that way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point!

rsasch
rsasch approved these changes Jul 23, 2021
View reviewed changes
Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small request, but otherwise 👍🏻

@RoriCremer RoriCremer merged commit 5d2c7dc into ah_var_store Jul 23, 2021
@RoriCremer RoriCremer deleted the rc-ac-an-af branch July 23, 2021 22:58
This was referenced Mar 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsasch rsasch rsasch approved these changes

@ahaessly ahaessly Awaiting requested review from ahaessly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RoriCremer @rsasch @ahaessly