Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VAT validation rule #2 [VS-19] #7374

Merged
merged 6 commits into from
Aug 2, 2021
Merged

Add VAT validation rule #2 [VS-19] #7374

merged 6 commits into from
Aug 2, 2021

Conversation

RoriCremer
Copy link
Contributor

@RoriCremer RoriCremer commented Jul 27, 2021

Unlike the other validation rules, this does not test the validity of the VAT, but whether the pipeline completed as we expected it to--so I have added this as the singular test that runs during the pipeline.

Validation Rule 2: The number of passing variants in GVS matches the number of variants in the VAT. Please note that we are counting the number of variants in GVS, not the number of sites, which may add a difficulty to this task.

Another way to phrase it: "If I were to make a sites only VCF of GVS and split each passing variant into it's own line, that number should equal the number of unique VIDs in the VAT."

Measure number of unique variants in sites only VCF that is generated.

We don't want to count filtered variants so we can't count the GVS table.

NOTE:

this pr also has some general cleanup as per discussion with Andrea.
where would y'all suggest I put the template file for the custom annotations?

@RoriCremer RoriCremer requested a review from ahaessly July 27, 2021 18:34
Copy link
Contributor

@ahaessly ahaessly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where to put the template. maybe in a google bucket?
another option is that we could inline it in the wdl.

otherwise 👍

@RoriCremer RoriCremer merged commit b24f091 into ah_var_store Aug 2, 2021
@RoriCremer RoriCremer deleted the rc-vs-19-vat-2 branch August 2, 2021 16:23
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants