Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VAT validation rule #7 [VS-14] and validation rule #6 [VS-15] #7379

Merged
merged 9 commits into from
Jul 29, 2021

Conversation

RoriCremer
Copy link
Contributor

@RoriCremer RoriCremer commented Jul 28, 2021

Closes https://broadworkbench.atlassian.net/browse/VS-15 by adding SQL for

No non-nullable / required fields contain null values in the VAT.

AND

Closes https://broadworkbench.atlassian.net/browse/VS-14 by adding SQL for

Each key combination (vid+transcript) is unique--confirms that primary key is enforced.

Screen Shot 2021-07-28 at 5 35 37 PM

@RoriCremer RoriCremer force-pushed the rc-vs-14-vat-7 branch 2 times, most recently from 041a248 to 0d0a230 Compare July 28, 2021 21:27
@RoriCremer RoriCremer changed the title Add VAT validation rule #7 [VS-14] Add VAT validation rule #7 [VS-14] and validation rule #6 [VS-15] Jul 28, 2021
@RoriCremer RoriCremer marked this pull request as ready for review July 29, 2021 13:22
@rsasch rsasch self-requested a review July 29, 2021 13:37
Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RoriCremer RoriCremer merged commit 7a724ff into ah_var_store Jul 29, 2021
@RoriCremer RoriCremer deleted the rc-vs-14-vat-7 branch July 29, 2021 18:35
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants