Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gnomad subpopulation info into the VAT #7381

Merged
merged 10 commits into from
Aug 10, 2021
Merged

Conversation

RoriCremer
Copy link
Contributor

@RoriCremer RoriCremer commented Jul 29, 2021

This adds the many gnomad subpopulations as columns into the VAT schema, and grabs most of them directly from the nirvana annotations. The max is done as a simple calculation in the python script and retains the order of subpops (for tie-breaking) that Lee specified

Copy link
Contributor

@ahaessly ahaessly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
are you going to make the annotations sub dir? these files probably belong there

@gatk-bot
Copy link

gatk-bot commented Aug 9, 2021

Travis reported job failures from build 35352
Failures in the following jobs:

Test Type JDK Job ID Logs
integration openjdk11 35352.12 logs

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes — looks good!

@RoriCremer RoriCremer merged commit b7ecfb9 into ah_var_store Aug 10, 2021
@RoriCremer RoriCremer deleted the rc-add-gnomad-vat branch August 10, 2021 14:53
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants