add option for create filter set to use sample_info with is_loaded #7434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove code that updated job id. only keep code that uses is_loaded
Overlapping code and wanting to test together
RoriCremer
reviewed
Aug 24, 2021
.dockstore.yml
Outdated
| @@ -92,6 +92,7 @@ workflows: | |||
| branches: | |||
| - master | |||
| - ah_var_store | |||
| - ah_use_is_loaded | |||
There was a problem hiding this comment.
dont forget to remove me!
RoriCremer
reviewed
Aug 24, 2021
| @@ -63,7 +66,7 @@ task PrepareCallsetTask { | |||
|
|
|||
| input { | |||
| String destination_cohort_table_prefix | |||
| File sample_names_to_extract | |||
| File? sample_names_to_extract | |||
There was a problem hiding this comment.
if there is no file, does it extract everything?
There was a problem hiding this comment.
if you don't supply a file it will extract everything where is_loaded is true
RoriCremer
reviewed
Aug 24, 2021
| } | ||
| } | ||
|
|
||
| # if (defined(sample_names_to_extract)) { |
There was a problem hiding this comment.
is this all for testing / still needed?
RoriCremer
approved these changes
Aug 24, 2021
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to use the is_loaded column to get the samples for training.
log job id
break up vet to vet_new queries
VS-165
VS-166
VS-167