Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quickstart #7439

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Update quickstart #7439

merged 1 commit into from
Aug 27, 2021

Conversation

ahaessly
Copy link
Contributor

update for assign ids and changes in import

Copy link
Contributor

@kcibul kcibul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@@ -19,12 +19,28 @@ This quickstart assumes that you are familiar with Terra workspaces, the data mo
- BigQuery data editor
- BigQuery job user
- BigQuery Read Session User
4. These tools expect reblocked gvcf files as input.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some kind of link for "Reblocking", like a GATK article or something? @ldgauthier ?


## 1. Import Data
In order to load data into BigQuery without hitting daily load limits, we recommend you group your input files into samples sets and follow these steps for each sample set.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you thinking of limits beyond the 15TB per load limit? If so and we have to chunk up the loads anyway, maybe we can remove all the 15TB logic from the WDL since it adds a lot of complexity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this was just a general comment as to why ops should load sample sets instead of individual samples. even though the logic for 15 TB is complicated, it is working well (well, after my other PR fix goes in). hopefully it won't actually be utilized much - but just as a fail safe

@ahaessly ahaessly merged commit 85ed00a into ah_var_store Aug 27, 2021
@ahaessly ahaessly deleted the ah_update_quickstart branch August 27, 2021 01:47
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants