Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added steps and deliverables to GVS README [VS-181] #7452

Merged
merged 40 commits into from
Sep 20, 2021
Merged

added steps and deliverables to GVS README [VS-181] #7452

merged 40 commits into from
Sep 20, 2021

Conversation

rsasch
Copy link

@rsasch rsasch commented Sep 1, 2021

@rsasch rsasch marked this pull request as draft September 1, 2021 22:39
@rsasch rsasch changed the title added steps and deliverables to README [VS-181] added steps and deliverables to GVS README [VS-181] Sep 1, 2021
ahaessly
ahaessly approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@ahaessly ahaessly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@rsasch
changes for GvsAssignIds and GvsImportGenomes
1c96f78
@rsasch
placeholder for Google request to enabble clustering
9791482
@rsasch
added debug statements to AssignIds
eeba187
@rsasch
more debug statements
aec2108
@rsasch
don't delete sample_id_assignment_lock table so I can look at it
03f5d08
@rsasch
Merge branch 'ah_var_store' into rsa_quickstart_updates
7160852
@rsasch
took out debugging added in check for 0 sample names
57a33d4
@rsasch
see if it makes a difference
772addc
@rsasch
put check back in, it does what it's supposed to
9eebf87
@rsasch
more quickstart README edits
9a22e26
@rsasch
Merge branch 'ah_var_store' into rsa_quickstart_updates
21b1728
@rsasch
removed unintentionally added file and more readme updates
c4eec8d
@rsasch
added GvsCreateAltAllele to .dockstore.yaml
8323c65
@rsasch
more dockstore fun
fdeee1d
@rsasch
more dockstore
8a97689
@rsasch
made CreateAltAlleleTable volatile
6a6c39f
@rsasch
whoops, populate should be volatile, too
ad99d9e
@rsasch
dockstore, again
c1babe6
@rsasch
more dockstore, again
c2cbf8c
@rsasch
yet more dockstore
0bd2199
@rsasch
yet more dockstore, again
bd343d7
@rsasch
Merge branch 'rsa_quickstart_updates' into rsa_aou_deliverables
c9067db
@rsasch
Merge branch 'ah_var_store' into rsa_aou_deliverables
b7714a9
@rsasch
slight re-factoring
6721795
@rsasch
Merge branch 'ah_var_store' into rsa_aou_deliverables
5558947
@gatk-bot
Copy link

gatk-bot commented Sep 14, 2021 •
edited
Loading

Travis reported job failures from build 36019
Failures in the following jobs:

Test Type JDK Job ID Logs
unit openjdk11 36019.13 logs
unit openjdk8 36019.3 logs

@rsasch rsasch marked this pull request as ready for review September 16, 2021 13:59
kbergin
kbergin requested changes Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@kbergin kbergin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for documenting this, Bec! Just some small comments

scripts/variantstore/README.md Outdated Show resolved Hide resolved
scripts/variantstore/README.md Outdated Show resolved Hide resolved
scripts/variantstore/README.md Outdated Show resolved Hide resolved
scripts/variantstore/README.md Outdated Show resolved Hide resolved
scripts/variantstore/README.md Show resolved Hide resolved
ahaessly
ahaessly approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@ahaessly ahaessly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 changes needed

scripts/variantstore/README.md Outdated Show resolved Hide resolved
ahaessly
ahaessly approved these changes Sep 16, 2021
View reviewed changes
scripts/variantstore/README.md Outdated Show resolved Hide resolved
scripts/variantstore/README.md Outdated Show resolved Hide resolved
@rsasch rsasch requested a review from kbergin September 16, 2021 16:31
@gatk-bot
Copy link

Travis reported job failures from build 36058
Failures in the following jobs:

Test Type JDK Job ID Logs
integration openjdk11 36058.12 logs

@kcibul
Copy link
Contributor

kcibul commented Sep 17, 2021

If this is specific to AoU, maybe we should rename this to indicate it's aou specific. README.md sounds more like it's the general readme for GVS

kcibul
kcibul approved these changes Sep 17, 2021
View reviewed changes
scripts/variantstore/README.md Outdated Show resolved Hide resolved
scripts/variantstore/README.md Outdated Show resolved Hide resolved
scripts/variantstore/README.md Outdated Show resolved Hide resolved
scripts/variantstore/README.md Outdated Show resolved Hide resolved
@rsasch rsasch requested a review from kcibul September 20, 2021 14:48
@gatk-bot
Copy link

Travis reported job failures from build 36112
Failures in the following jobs:

Test Type JDK Job ID Logs
integration openjdk11 36112.12 logs

@rsasch rsasch merged commit 2e16fd0 into ah_var_store Sep 20, 2021
@rsasch rsasch deleted the rsa_aou_deliverables branch September 20, 2021 20:49
This was referenced Mar 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbergin kbergin kbergin approved these changes

@kcibul kcibul Awaiting requested review from kcibul

@ahaessly ahaessly Awaiting requested review from ahaessly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rsasch @gatk-bot @kcibul @kbergin @ahaessly