Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional workflow and README updates for Quickstart [VS-183] #7463

Merged
merged 21 commits into from
Sep 10, 2021

Conversation

rsasch
Copy link

@rsasch rsasch commented Sep 9, 2021

  • added GvsAssignIds to .dockstore.yaml
  • added logic to GvsAssignIds to prevent bug from empty input
  • updates to Quickstart README directions

Closes https://broadworkbench.atlassian.net/browse/VS-183

Copy link
Contributor

@kcibul kcibul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but a little confused about removing that external sample id field


These are the required parameters which must be supplied to the workflow:

| Parameter | Description |
| ----------------- | ----------- |
| project_id | The name of the google project containing the dataset |
| dataset_name | The name of the dataset you created above |
| external\_sample_names | Use `this.samples.sample_id` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a required parameter to the workflow?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, but when the user clones and then runs the workflow, the saved inputs should be populated automatically. I thought that was how it was set up before, so I was going along with that method, but I'd also be happy to put that in.

@gatk-bot
Copy link

gatk-bot commented Sep 9, 2021

Travis reported job failures from build 35935
Failures in the following jobs:

Test Type JDK Job ID Logs
integration openjdk11 35935.12 logs

@gatk-bot
Copy link

gatk-bot commented Sep 9, 2021

Travis reported job failures from build 35951
Failures in the following jobs:

Test Type JDK Job ID Logs
integration openjdk11 35951.12 logs

@rsasch rsasch merged commit f2327a3 into ah_var_store Sep 10, 2021
@rsasch rsasch deleted the rsa_quickstart_updates branch September 10, 2021 14:05
@rsasch rsasch restored the rsa_quickstart_updates branch September 10, 2021 14:05
This was referenced Mar 17, 2023
@rsasch rsasch deleted the rsa_quickstart_updates branch October 24, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants