Propagated all hidden arguments in gCNV CASE mode from the given model #7464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d CopyNumberCallingConfig arguments from the input model configuration.
mwalker174
requested changes
Sep 14, 2021
There was a problem hiding this comment.
Let's add a documentation and checks on the Java side for when users try to specify hidden parameters with this:
final CommandLineArgumentParser clpParser = (CommandLineArgumentParser) getCommandLineParser();
final boolean isOutputSet = clpParser.getNamedArgumentDefinitionByAlias(StandardArgumentDefinitions.OUTPUT_LONG_NAME).getHasBeenSet();
and throw an error.
| * then specified by a file contained in the model directory, all interval-related arguments are ignored in this | ||
| * mode, and all model intervals must be present in all of the input count files. The tool output in CASE mode | ||
| * is only the "-calls" subdirectory and is organized similarly to that in COHORT mode.</p> | ||
| * then specified by a file contained in the model directory,and all model intervals must be present in all of the |
There was a problem hiding this comment.
directory,and -> directory, and
| * mode, and all model intervals must be present in all of the input count files. The tool output in CASE mode | ||
| * is only the "-calls" subdirectory and is organized similarly to that in COHORT mode.</p> | ||
| * then specified by a file contained in the model directory,and all model intervals must be present in all of the | ||
| * input count files. All interval-related arguments (e.g. {@code interval-psi-scale} argument) are ignored in this |
There was a problem hiding this comment.
(e.g. {@code interval-psi-scale} argument) -> (e.g. {@code interval-psi-scale})
| * is only the "-calls" subdirectory and is organized similarly to that in COHORT mode.</p> | ||
| * then specified by a file contained in the model directory,and all model intervals must be present in all of the | ||
| * input count files. All interval-related arguments (e.g. {@code interval-psi-scale} argument) are ignored in this | ||
| * mode, however an advanced user can adjust various sample-related (e.g. {@code sample-psi-scale}) and global |
There was a problem hiding this comment.
mode, however -> mode. However,
| * input count files. All interval-related arguments (e.g. {@code interval-psi-scale} argument) are ignored in this | ||
| * mode, however an advanced user can adjust various sample-related (e.g. {@code sample-psi-scale}) and global | ||
| * (e.g. {@code p_alt}) arguments for custom applications of the tool. Inference-related (e.g. | ||
| * {@code min_training_epochs}) arguments can be adjusted as well. The tool output in CASE mode is only the "-calls" |
There was a problem hiding this comment.
Inference-related (e.g. {@code min_training_epochs}) arguments -> Inference-related arguments (e.g. {@code min_training_epochs})
|
Random request, but maybe let's add a link to the white paper at https://github.com/broadinstitute/gatk/blob/master/docs/CNV/germline-cnv-caller-model.pdf while you're touching up the tool docs? |
asmirnov239
force-pushed
the
as_gcnv_clean_up_model_mismatch_warnings
branch
from
d80d049
to
08f38d9
Compare
|
@samuelklee I will add that to the documentation as well. |
asmirnov239
force-pushed
the
as_gcnv_clean_up_model_mismatch_warnings
branch
2 times, most recently
from
17bc5bf
to
ca5c0ee
Compare
|
@mwalker174 Thank you for the comments! Back to you |
…if any arguments not applicable in CASE mode were set by the user.
asmirnov239
force-pushed
the
as_gcnv_clean_up_model_mismatch_warnings
branch
from
ca5c0ee
to
c8b5266
Compare
mwalker174
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gCNV in the CASE mode now fills in all hidden DenoisingModelConfig and CopyNumberCallingConfig arguments from the input model configuration.
This addresses issue #6994