Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GenotypeGVCFs bug for variants with zero or no INFO DP #7491

Merged
merged 3 commits into from
Oct 6, 2021

Conversation

ldgauthier
Copy link
Contributor

Variants with zero or no INFO DP were not having their annotations finalized, which output some lovely AlleleSpecificAnnotationData Objects in the VCF.

Clean up raw annotations for AS_QD
(I'm so sure I added the input files this time)
@ldgauthier ldgauthier requested a review from vruano October 4, 2021 20:33
@gatk-bot
Copy link

gatk-bot commented Oct 4, 2021

Travis reported job failures from build 36275
Failures in the following jobs:

Test Type JDK Job ID Logs
integration openjdk11 36275.12 logs
integration openjdk8 36275.2 logs

Copy link
Contributor

@vruano vruano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good, I'm assuming the change in sematics is what is intended and needed.

@vruano
Copy link
Contributor

vruano commented Oct 6, 2021

Approved.

@ldgauthier ldgauthier merged commit ec514b7 into master Oct 6, 2021
@ldgauthier ldgauthier deleted the ldg_fixAS_QD branch October 6, 2021 16:05
gileshall pushed a commit that referenced this pull request Oct 6, 2021
Catch corner case for DP=0/no DP variants
Clean up raw annotations for AS_QD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants