Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sites only step from the VAT creation WDL #7510

Merged
merged 26 commits into from
Oct 28, 2021

Conversation

RoriCremer
Copy link
Contributor

Move the creation of the sites only vcf into the bcftools step

@RoriCremer RoriCremer force-pushed the rc-remove-sites-only-step branch 4 times, most recently from a2210d0 to ea40cc7 Compare October 22, 2021 20:30
@RoriCremer RoriCremer force-pushed the rc-remove-sites-only-step branch 2 times, most recently from a2a5102 to e2603bb Compare October 22, 2021 20:43
@rsasch rsasch self-requested a review October 25, 2021 13:49
Comment on lines 214 to 219
#awk '{print $2}' ~{subpopulation_sample_list} | tail -n +2 | sort -u > collected_subpopulations.txt
#bcftools query --list-samples ~{local_input_vcf} | sort -u > collected_samples.txt

#wc -l collected_subpopulations.txt
#wc -l collected_samples.txt

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these lines commented out?

bcftools view -i 'N_ALT>500 || REF~"N"' ~{local_input_vcf} | bcftools query -f '%CHROM\t%POS\t%ID\t%REF\t%ALT\n' > track_dropped.tsv

## Since Nirvana cant handle N as a base, drop them for now and keep track of the lines dropped
## bcftools view -e 'REF~"N"' ~{local_input_vcf}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this line commented out?

@RoriCremer RoriCremer marked this pull request as ready for review October 26, 2021 19:11
@RoriCremer RoriCremer merged commit 308b870 into ah_var_store Oct 28, 2021
@RoriCremer RoriCremer deleted the rc-remove-sites-only-step branch October 28, 2021 20:12
@RoriCremer RoriCremer restored the rc-remove-sites-only-step branch October 28, 2021 20:12
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants