Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bool flag in prepare #7529

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Fix bool flag in prepare #7529

merged 1 commit into from
Oct 29, 2021

Conversation

ahaessly
Copy link
Contributor

@ahaessly ahaessly commented Oct 28, 2021 •
edited
Loading

fix bad argument processing for bool
fix param name

@ahaessly ahaessly requested a review from kcibul October 28, 2021 16:05
kcibul
kcibul approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@kcibul kcibul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- can you also build a new docker for the python and update this line:

String docker_final = select_first([docker, "us.gcr.io/broad-dsde-methods/variantstore:ah_flag_in_prepare"])

@ahaessly ahaessly merged commit fb67e8e into ah_var_store Oct 29, 2021
@ahaessly ahaessly deleted the ah_fix_python_bool_flag branch October 29, 2021 18:58
This was referenced Mar 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcibul kcibul kcibul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahaessly @kcibul