Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ah add reblocking wdl #7544

Merged
merged 13 commits into from
Nov 8, 2021
Merged

Ah add reblocking wdl #7544

merged 13 commits into from
Nov 8, 2021

Conversation

ahaessly
Copy link
Contributor

@ahaessly ahaessly commented Nov 4, 2021

No description provided.

@kbergin
Copy link
Collaborator

kbergin commented Nov 4, 2021

Can I confirm that this reblocking workflow is matching the new 4 band reblocking schema in the released WARP reblocking pipeline?

If this reblocking wdl is AoU specific can we add AoU into the name? (Kris's comment in slack that I'd like to plus one). If it's not AoU specific I'd want to explore if we can use the released version of Reblocking already in Terra instead.

@ahaessly
Copy link
Contributor Author

ahaessly commented Nov 4, 2021

Yes, it is running with the new 4 band option. It is specific to AoU so I will rename as such.
There is the option of importing the warp reblocking task and calling it instead of rewriting the task. The downside is that we will be spinning up a vm 2 extra times per sample to do the localization. (Since we rewrote the task in this version of the wdl, we do the localization/delocalization on the same vm that does the reblocking).

@ahaessly ahaessly merged commit fbbea88 into ah_var_store Nov 8, 2021
@ahaessly ahaessly deleted the ah_add_reblocking branch November 8, 2021 20:37
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants