Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes to ImportGenomes (non-write api version) #7574

Merged
merged 5 commits into from
Nov 20, 2021
Merged

Small fixes to ImportGenomes (non-write api version) #7574

merged 5 commits into from
Nov 20, 2021

Conversation

rsasch
Copy link

@rsasch rsasch commented Nov 19, 2021

  • localization_optional for indexes localization in CreateImportTsvs
  • check to make sure there are more than 0 samples to load before going forward in GetSampleIds

kcibul
kcibul approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@kcibul kcibul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also copied into my write-based PR so thanks!!

ahaessly
ahaessly approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@ahaessly ahaessly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rsasch rsasch merged commit bd432c1 into ah_var_store Nov 20, 2021
@rsasch rsasch deleted the rsa_import_indexes_localization branch November 20, 2021 19:28
This was referenced Mar 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcibul kcibul kcibul approved these changes

@ahaessly ahaessly ahaessly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsasch @kcibul @ahaessly