read api bytes logging, upgrade bigquery client versions #7601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoriCremer
reviewed
Dec 13, 2021
src/main/java/org/broadinstitute/hellbender/tools/gvs/extract/ExtractCohort.java
Outdated
Show resolved
Hide resolved
RoriCremer
reviewed
Dec 13, 2021
|
|
||
| import io.netty.util.internal.StringUtil; |
There was a problem hiding this comment.
why is this change needed? or is it part of one of the upgrades?
There was a problem hiding this comment.
We were importing the "shaded" version of this before which isn't really the library, but gradle's repackaging of it and it's not stable. This is the public version.
RoriCremer
approved these changes
Dec 13, 2021
rsasch
approved these changes
Dec 17, 2021
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR was to output the new estimated bytes read from the Read API for better monitoring and debugging.
However in the course of that I discovered that we were using ancient versions of the google APIs. No massive improvements from the release logs, but a lot of nice features (cleaner logging, automatic retries for certain errors, )
bigQuery 1.131.1 -> 2.3.3 Release log for bigQuery
bigQueryStorage 1.22.3 -> 2.5.0 Release log for bigQueryStorage