Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade log4j to 2.17 #7616

Merged
merged 1 commit into from
Dec 20, 2021
Merged

upgrade log4j to 2.17 #7616

merged 1 commit into from
Dec 20, 2021

Conversation

kcibul
Copy link
Contributor

@kcibul kcibul commented Dec 20, 2021

No description provided.

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (🤞🏻 the tests pass)

Copy link
Contributor

@ahaessly ahaessly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kcibul kcibul merged commit 07489bf into ah_var_store Dec 20, 2021
@kcibul kcibul deleted the kc_log4j_upgrade_217 branch December 20, 2021 18:49
@aofarrel
Copy link
Contributor

aofarrel commented Jan 3, 2022

@lbergelson I cannot update #7611 with these changes until the Docker image(s) are regenerated, as WDL workflows (in this context) point to a Docker image. Since an image with these changes isn't currently on DockerHub, those workflows remain insecure.

I would like to propose tagging a new release (4.2.4.1) that contains #7616 and pushing those as tag 4.2.4.1 onto DockerHub. Once that is done, I can update the workflows accordingly.

context: #7617 (comment)

@lbergelson
Copy link
Member

@aofarrel Yes, I'm going to do that very soon.

This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants