Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

presorted avro files, fix performance issue #7635

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Conversation

kcibul
Copy link
Contributor

@kcibul kcibul commented Jan 11, 2022

No description provided.

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, otherwise 👍🏻 (once tests pass....etc.)

for(Long s : samples) {
ExtractCohortRecord e = processReferenceData(sortedReferenceRangeIterator, referenceCache, location, s);
currentPositionRecords.merge(s, e, this::mergeSampleRecord);
// List<Long> samples = sampleIdsToExtract.stream().filter(x -> x >= fromSampleId && x <= toSampleId).sorted().collect(toList());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should this line just be deleted?

@kcibul
Copy link
Contributor Author

kcibul commented Jan 12, 2022

Also confirmed identical results when running against the 10-sample quickstart data

@kcibul kcibul merged commit 8a17ca2 into ah_var_store Jan 12, 2022
@kcibul kcibul deleted the kc_extract_perf branch January 12, 2022 18:32
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants