Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There something about split intervals #7694

Merged
merged 12 commits into from
Mar 2, 2022
Merged

Conversation

RoriCremer
Copy link
Contributor

@RoriCremer RoriCremer commented Feb 23, 2022

on the ah_var_store branch, the SplitIntervals file didn't match up with main, and it looks like there are some problems with the --interval-file-num-digits 10 flag.

I need to further investigate what is going on (and why we reverted!??!)

@droazen
Copy link
Collaborator

droazen commented Feb 23, 2022

@RoriCremer These arguments were added to SplitIntervals in #7488 back in October.

@RoriCremer
Copy link
Contributor Author

RoriCremer commented Feb 28, 2022

@rsasch LGTM.... worked for me, and it looks like the testing all passed---lmk how else I can help

@rsasch rsasch merged commit dab3253 into ah_var_store Mar 2, 2022
@rsasch rsasch deleted the rc-split-intervals-odd branch March 2, 2022 15:37
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants