Add task to ExtractCallset that verifies filter_set_name exists in GVS dataset [VS-335] #7734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsasch
changed the title
RoriCremer
reviewed
Mar 22, 2022
| exit 1 | ||
| fi | ||
| >>> | ||
| output { |
There was a problem hiding this comment.
awesome---would we ever want to re-use this code as a validation before we make the filter model to make sure the filter name doesn't already exist ?
There was a problem hiding this comment.
I'm hesitant to add more validation than was requested by users into individual WDLs because, I think it makes more sense, once we have one WDL to rule them all, to have an all-in-one validation step that sanity checks all the inputs before running.
RoriCremer
approved these changes
Mar 22, 2022
rsasch
changed the title
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://broadworkbench.atlassian.net/browse/VS-335