Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for gatk to be overridden, update with known good jar #7758

Merged
merged 2 commits into from
Apr 6, 2022

Conversation

kcibul
Copy link
Contributor

@kcibul kcibul commented Apr 6, 2022

No description provided.

@kcibul kcibul requested a review from rsasch April 6, 2022 14:30
@@ -14,6 +14,8 @@ workflow GvsCreateFilterSet {
Array[String] snp_recalibration_annotation_values = ["AS_QD", "AS_MQRankSum", "AS_ReadPosRankSum", "AS_FS", "AS_MQ", "AS_SOR"]

File interval_list = "gs://gcp-public-data--broad-references/hg38/v0/wgs_calling_regions.hg38.noCentromeres.noTelomeres.interval_list"
File gatk_override = "gs://broad-dsp-spec-ops/scratch/bigquery-jointcalling/jars/ah_var_store_20220406/gatk-package-4.2.0.0-480-gb62026a-SNAPSHOT-local.jar"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to store this as a var in all the WDLs so we only have to update it in one place and wont accidentally miss workflows?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and maybe do GvsPrepareRangesCallset too?

....and we should really delete the orig GvsPrepareCallset!

@kcibul kcibul merged commit d07a944 into ah_var_store Apr 6, 2022
@kcibul kcibul deleted the kc_wdl_gatk_override branch April 6, 2022 19:07
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants