Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic Sample ID assignments [VS-371] #7770

Merged
merged 7 commits into from
Apr 13, 2022

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Apr 11, 2022

The syntax is a little 🙁 but this does appear to work. Sample ids should now be assigned according to the sort order of the names of the samples being uploaded in this invocation of GvsAssignIds (existing sample ids should not be affected).

Before:

Screen Shot 2022-04-11 at 1 28 32 PM

After:

Screen Shot 2022-04-11 at 1 29 07 PM

@mcovarr mcovarr changed the title Vs 371 assignids deterministic Deterministic Sample ID assignments [VS-371] Apr 11, 2022
Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@mcovarr mcovarr requested a review from RoriCremer April 13, 2022 12:09
@mcovarr mcovarr merged commit 1fecbf9 into ah_var_store Apr 13, 2022
@mcovarr mcovarr deleted the vs_371_assignids_deterministic branch April 13, 2022 18:08
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants