Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up LocalizeFile [VS-314] #7771

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Apr 11, 2022

I actually found a LocalizeFile in two different (though possibly related) WDLs where it was not being used so I removed it from both.

@mcovarr mcovarr changed the base branch from master to ah_var_store April 11, 2022 20:08
@mcovarr mcovarr marked this pull request as ready for review April 11, 2022 21:09
@mcovarr mcovarr requested review from rsasch and gbggrant April 13, 2022 12:08
Copy link
Collaborator

@gbggrant gbggrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(FYI, we aren't using GvsPrepareCallset.wdl anymore so you could delete it)

@mcovarr mcovarr force-pushed the vs_314_clean_up_localizefile branch from 49b2551 to 0f67c7d Compare April 14, 2022 13:14
@mcovarr mcovarr merged commit 43a1480 into ah_var_store Apr 14, 2022
@mcovarr mcovarr deleted the vs_314_clean_up_localizefile branch April 14, 2022 14:30
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants