Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove R scripts from filtering #7781

Merged
merged 2 commits into from
Apr 14, 2022
Merged

remove R scripts from filtering #7781

merged 2 commits into from
Apr 14, 2022

Conversation

RoriCremer
Copy link
Contributor

@RoriCremer RoriCremer commented Apr 13, 2022 •
edited
Loading

In a step from CreateFilterSet, I was hitting what looks like an R limit

Longest line length was 101,412 on the failing shard

image

gbggrant
gbggrant approved these changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@gbggrant gbggrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Long term, I'd suggest we make this an optional input and determine if it is also generating a pdf and capture that as an output.

@RoriCremer RoriCremer merged commit 8a4f8df into ah_var_store Apr 14, 2022
@RoriCremer RoriCremer deleted the rc-remove-r-graphing-from-filter branch April 14, 2022 00:43
This was referenced Mar 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbggrant gbggrant gbggrant approved these changes

@mcovarr mcovarr mcovarr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RoriCremer @gbggrant @mcovarr