Pinned typing_extensions python package to 4.1.1 to fix conda environment. #7802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesemery
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
👍 Thank you @samuelklee. I absolutely think this is the right thing in the short term to un-block master and my intention with #7801 was if anything somewhat of a threat. I still maintain that our intention for the conda envrionment when its not being actively developed should be locked down such that this never possibly could have happened in the first place.
mcovarr
pushed a commit
that referenced
this pull request
Apr 21, 2022
…ment. (#7802) * Pinned typing_extensions python package to 4.1.1 to fix conda environment. * Added documentation comment to conda environment.
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lbergelson @jamesemery I'm on vacation, but saw #7800 and #7801 go by in the gatk4-github Slack channel. Just curious to see if this will work on Travis and/or Github Actions---can you take it from here, if needed?
I've confirmed that this branch works locally in my Ubuntu environment and that
import gcnvkernelandimport sklearnboth work in the resulting environment (whereas these imports failed in master, although the environment built successfully---this seems to mirror what is happening on test infrastructure in #7800).In contrast, the approach in #7801 doesn't seem to work for me locally, and we've seen that including conda build strings is a bit restrictive. See e.g. #5026 (comment).
Closes #7800.