Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs clarification for some reblocking-related funkiness #7846

Merged
merged 1 commit into from
May 11, 2022

Conversation

ldgauthier
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #7846 (7a30ea4) into master (a3141f7) will decrease coverage by 0.006%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #7846       +/-   ##
===============================================
- Coverage     86.955%   86.948%   -0.006%     
- Complexity     36920     36927        +7     
===============================================
  Files           2218      2219        +1     
  Lines         173663    173673       +10     
  Branches       18751     18755        +4     
===============================================
- Hits          151008    151006        -2     
- Misses         16049     16055        +6     
- Partials        6606      6612        +6     
Impacted Files Coverage Δ
.../hellbender/tools/walkers/GenotypeGVCFsEngine.java 90.826% <ø> (ø)
...tools/walkers/haplotypecaller/HaplotypeCaller.java 85.714% <0.000%> (-6.286%) ⬇️
...notyper/GenotypeCalculationArgumentCollection.java 89.474% <0.000%> (ø)
...otypecaller/HaplotypeCallerArgumentCollection.java 100.000% <0.000%> (ø)
...typecaller/LikelihoodEngineArgumentCollection.java 100.000% <0.000%> (ø)
...ecaller/AssemblyBasedCallerArgumentCollection.java 100.000% <0.000%> (ø)
...nstitute/hellbender/cmdline/ModeArgumentUtils.java 69.231% <0.000%> (ø)
...tute/hellbender/engine/AssemblyRegionIterator.java 92.784% <0.000%> (+0.152%) ⬆️

@ldgauthier
Copy link
Contributor Author

@droazen I'm not thrilled that adding Javadoc decreased our coverage, but we've gone for years without code coverage, so I can just ignore this.

@ldgauthier ldgauthier merged commit 72684d0 into master May 11, 2022
@ldgauthier ldgauthier deleted the ldgauthier-patch-1 branch May 11, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants