Compute filter scatter [VS-392] #7852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ah_var_store #7852 +/- ##
================================================
Coverage ? 86.293%
Complexity ? 35194
================================================
Files ? 2170
Lines ? 164876
Branches ? 17783
================================================
Hits ? 142277
Misses ? 16276
Partials ? 6323 |
mcovarr
approved these changes
May 16, 2022
RoriCremer
reviewed
May 17, 2022
RoriCremer
approved these changes
May 17, 2022
gbggrant
approved these changes
May 17, 2022
| @@ -70,6 +69,11 @@ workflow GvsCreateFilterSet { | |||
| project_id = project_id | |||
| } | |||
|
|
|||
| Int scatter_count = if GetNumSamplesLoaded.num_samples < 100 then 20 | |||
There was a problem hiding this comment.
Suggested change
| Int scatter_count = if GetNumSamplesLoaded.num_samples < 100 then 20 | |
| Int scatter_count = if GetNumSamplesLoaded.num_samples < 100 then 20 | |
| else if GetNumSamplesLoaded.num_samples < 1000 then 100 | |
| else if GetNumSamplesLoaded.num_samples < 10000 then 200 | |
| else if GetNumSamplesLoaded.num_samples < 100000 then 500 | |
| else 1000``` |
There was a problem hiding this comment.
Might be a little cleaner?
There was a problem hiding this comment.
I went with the formatting that the Winstanley plugin recommended, although I like the way your suggestion looks,.
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://broadworkbench.atlassian.net/browse/VS-392