Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Input Validation python notebook #7853

Merged
merged 3 commits into from
May 23, 2022
Merged

Fix Input Validation python notebook #7853

merged 3 commits into from
May 23, 2022

Conversation

gbggrant
Copy link
Collaborator

Multiple bug fixes:

  • Load entity_types
  • Properly handle case where gvcf or index NOT found.

@gbggrant
Multiple bug fixes:
572492d 
- Load entity_types
- Properly handle case where gvcf or index NOT found.
@gbggrant gbggrant requested a review from mcovarr May 17, 2022 16:23
@codecov
Copy link

codecov bot commented May 17, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@6767947). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             ah_var_store     #7853   +/-   ##
================================================
  Coverage                ?   86.296%           
  Complexity              ?     35191           
================================================
  Files                   ?      2170           
  Lines                   ?    164876           
  Branches                ?     17784           
================================================
  Hits                    ?    142282           
  Misses                  ?     16270           
  Partials                ?      6324

@gbggrant gbggrant marked this pull request as ready for review May 17, 2022 18:05
@gbggrant gbggrant removed the request for review from mcovarr May 17, 2022 19:21
rsasch
rsasch approved these changes May 19, 2022
View reviewed changes
Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it and it looked 👍🏻

mcovarr
mcovarr approved these changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbggrant gbggrant merged commit e7539d5 into ah_var_store May 23, 2022
@gbggrant gbggrant deleted the gg_FixInputValidation branch May 23, 2022 13:33
This was referenced Mar 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsasch rsasch rsasch approved these changes

@mcovarr mcovarr mcovarr approved these changes

@kcibul kcibul Awaiting requested review from kcibul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gbggrant @rsasch @mcovarr